fix: prevent zombies in transcoding

navidrome · Feb 15, 2020 · e6d717c · e6d717c
1 parent b7f1fc0
commit e6d717c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/engine/media_streamer.go b/engine/media_streamer.go
@@ -212,7 +212,11 @@ func newTranscode(ctx context.Context, path string, maxBitRate int, format strin
 	if f, err = cmd.StdoutPipe(); err != nil {
 		return f, err
 	}
-	return f, cmd.Start()
+	if err = cmd.Start(); err != nil {
+		return f, err
+	}
+	go cmd.Wait() // prevent zombies
+	return f, err
 }
 
 func createTranscodeCommand(path string, maxBitRate int, format string) (string, []string) {