Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Lower Default Volume #1052

Closed
ghost opened this issue Apr 25, 2021 · 11 comments
Closed

[Feature Request] Lower Default Volume #1052

ghost opened this issue Apr 25, 2021 · 11 comments

Comments

@ghost
Copy link

ghost commented Apr 25, 2021

Is your feature request related to a problem? Please describe.

The first time you start audio in the web interface, it can be quite deafening.

Describe the solution you'd like

Either:

  • A lower default volume to begin with
  • A configurable default volume through an environment variable

Describe alternative solutions that would also satisfy this problem

Simply having the first-time volume put into localStorage as something lower than 100% would be fantastic, if nothing else.

Additional context

Reddit discussion link.

@ghost ghost added the enhancement label Apr 25, 2021
@jvoisin
Copy link
Collaborator

jvoisin commented Apr 25, 2021

This seems to be an issue with your operating system volume settings.

@certuna
Copy link
Contributor

certuna commented Apr 28, 2021

Yeah I'm a bit puzzled by this - is Navidrome louder than other websites?

@deluan
Copy link
Member

deluan commented May 24, 2021

Hey @xnaas maybe the issue you are experiencing is related to this? lijinke666/react-music-player#379

@ghost
Copy link
Author

ghost commented May 24, 2021

@deluan: maybe, maybe not? I'm not sure if it's quite the same issue or not. I don't know if that change would resolve full logouts as well as just closing the player.

@deluan deluan closed this as completed in 24d4c81 Jul 5, 2021
@deluan
Copy link
Member

deluan commented Jul 5, 2021

Hey @xnaas, after a big refactor in the Player state management code, I was able to set a default value. Please check if this solves the issue for you. If not, feel free to reopen the issue.

@ghost
Copy link
Author

ghost commented Jul 6, 2021

@deluan: Is this a change that's already pushed to a released version, or do I need to build from source to test?

@deluan
Copy link
Member

deluan commented Jul 6, 2021

It is in the latest dev build: https://github.com/navidrome/navidrome/actions/runs/1002861479 (click on the binaries artifact at the bottom). Also in Docker, by using the tag deluan/navidrome:develop.

But if you prefer to wait for a release, thats fine. Should be end of this month.

@ghost
Copy link
Author

ghost commented Jul 7, 2021

Version: | 0.44.1-SNAPSHOT (b34d77f)

Still quite loud, but it is technically lower. Would definitely love if this was configurable via an Environment Variable or some such. 😅


Edit: What I find interesting is that the value you set in 24d4c81 is 0.5, but this looks more like 0.75 or something to me:

volume

@deluan
Copy link
Member

deluan commented Jul 14, 2021

Yeah, this is due to the way the React-Player implements logarithmic volume: lijinke666/react-music-player#266 Will probably change it to be really 50%

Adding a config option for this is adding more code to maintain and unless there are more users affected by it, it is not worth (IMHO). Hope reducing it to real 50% will make it better

@ghost
Copy link
Author

ghost commented Jul 14, 2021

Yeah, this is due to the way the React-Player implements logarithmic volume: lijinke666/react-music-player#266 Will probably change it to be really 50%

Ah, makes sense. Thanks for the info.

Adding a config option for this is adding more code to maintain and unless there are more users affected by it, it is not worth (IMHO).

Fair enough; it's your project, not mine. :D

Hope reducing it to real 50% will make it better

Definitely will. Thanks again. :)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants