-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Lower Default Volume #1052
Comments
This seems to be an issue with your operating system volume settings. |
Yeah I'm a bit puzzled by this - is Navidrome louder than other websites? |
Hey @xnaas maybe the issue you are experiencing is related to this? lijinke666/react-music-player#379 |
@deluan: maybe, maybe not? I'm not sure if it's quite the same issue or not. I don't know if that change would resolve full logouts as well as just closing the player. |
Hey @xnaas, after a big refactor in the Player state management code, I was able to set a default value. Please check if this solves the issue for you. If not, feel free to reopen the issue. |
@deluan: Is this a change that's already pushed to a released version, or do I need to build from source to test? |
It is in the latest dev build: https://github.com/navidrome/navidrome/actions/runs/1002861479 (click on the binaries artifact at the bottom). Also in Docker, by using the tag But if you prefer to wait for a release, thats fine. Should be end of this month. |
Yeah, this is due to the way the React-Player implements logarithmic volume: lijinke666/react-music-player#266 Will probably change it to be really 50% Adding a config option for this is adding more code to maintain and unless there are more users affected by it, it is not worth (IMHO). Hope reducing it to real 50% will make it better |
Ah, makes sense. Thanks for the info.
Fair enough; it's your project, not mine. :D
Definitely will. Thanks again. :) |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Is your feature request related to a problem? Please describe.
The first time you start audio in the web interface, it can be quite deafening.
Describe the solution you'd like
Either:
Describe alternative solutions that would also satisfy this problem
Simply having the first-time volume put into
localStorage
as something lower than 100% would be fantastic, if nothing else.Additional context
Reddit discussion link.
The text was updated successfully, but these errors were encountered: