Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume & Volume Slider sometimes rises when skipping song (Web UI 0.45.0) #1297

Closed
wanieru opened this issue Aug 22, 2021 · 15 comments
Closed
Labels

Comments

@wanieru
Copy link

wanieru commented Aug 22, 2021

Description

In the web UI, sometimes, the volume slider will start increasing every time the song is skipped, until maxing out at 100%.

Expected Behaviour

The volume slider should not change until the user changes it.

Steps to reproduce

  1. Queue multiple songs
  2. Change the volume slightly, between 2-10%
  3. Skip to the next song
  4. Notice if the volume slider rises. If not, repeat step 2.
  5. Skip to the next song again.
  6. Notice how the volume rises once again. Repeat step 5 until volume maxes out at 100%

Platform information

  • Navidrome version: 0.45.0
  • Browser and version: Firefox 91.0.1 (64-bit)
  • Operating System: Windows 10

Additional information

Check out this video, I sent on the Discord, which shows the problem:
https://cdn.discordapp.com/attachments/671335427726114839/878021964978069604/Cy76d8BCWh.mp4

@wanieru wanieru added the bug label Aug 22, 2021
@deluan
Copy link
Member

deluan commented Aug 22, 2021

Thanks for reporting! Latest development build should fix it, can you please try it?

@wanieru
Copy link
Author

wanieru commented Aug 23, 2021

Yep, it seems to work! Thanks a lot!

@wanieru wanieru closed this as completed Aug 23, 2021
@mradermaxlol
Copy link

@deluan any ETA for the next release containing this fix?

@deluan
Copy link
Member

deluan commented Aug 23, 2021

Probably today. I'm trying to validate another fix, so it can be included in this bug fix release

@mill1000
Copy link
Contributor

mill1000 commented Aug 24, 2021

Using the latest commit c55e659 I've noticed a strange volume slider behavior.

When starting playback the volume starts at 50%. I then increase volume to 100% and click next track. The slider jumps downward. Each new track the slider shifts slight more right until it reaches 100%.

Animation

EDIT: Just checked that the issue I'm describing it present in v0.44 snapshots as well.

@deluan
Copy link
Member

deluan commented Sep 3, 2021

@mill1000 Can you try with 0.43.0? This may be an issue with the upstream react music player...

@mill1000
Copy link
Contributor

mill1000 commented Sep 4, 2021

@deluan I tried downgrading to v0.43.0 but I can't seem to login. I wiped my database and cache but I keep getting "Error: Method Not Allowed" when trying to create a new admin user.

Sep 03 18:49:27 RockHole navidrome[19800]: time="2021-09-03T18:49:27-06:00" level=warning msg="HTTP: POST http://rockhole:4533/auth/createAdmin" elapsedTime="72.332µs" httpStatus=405 remoteAddr="192.168.1.136:50919" requestId=RockHole/pUC8gHLfDu-000022 responseSize=0 userAgent="Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0"

@deluan
Copy link
Member

deluan commented Sep 4, 2021

Ops, I forgot to tell you you'll need to use a fresh installation for this test with 0.43.0. The databases from 0.44.0 and 0.43.0 are not compatible.

@mill1000
Copy link
Contributor

mill1000 commented Sep 4, 2021

I thought I blew them away but I'll give it another shot.

@mill1000
Copy link
Contributor

mill1000 commented Sep 4, 2021

No luck. Removed the database files and cache form /var/lib/navidrome. Is there something incompatible in the config file between 0.43 and 0.44?

@mill1000
Copy link
Contributor

mill1000 commented Sep 4, 2021

NVM. Got it working. I was building my own release of 0.43 instead of grabbing it from releases.

This volume issues does not appear to be present in v0.43.0.

@deluan
Copy link
Member

deluan commented Sep 4, 2021

Thanks for the feedback. Will take a look.

@deluan deluan reopened this Sep 4, 2021
@mill1000
Copy link
Contributor

mill1000 commented Sep 4, 2021

@deluan You can close this after all. I've been building my own releases and I've just noticed that make single does not build the frontend. All along I've been testing with an updated backend and an out of date frontend.

Using the official v0.45.1 release I am not seeing this volume issue.

deluan added a commit that referenced this issue Sep 6, 2021
@deluan
Copy link
Member

deluan commented Sep 6, 2021

Great it worked! I added a warning message to all make targets that only build the server, thanks for the tip.

@deluan deluan closed this as completed Sep 6, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants