Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swallows up to a second at the end of each track. Displayed length in Navidrome does not match the file either. #1926

Closed
K4r0qtuYNE5G4qgZ opened this issue Oct 10, 2022 · 4 comments

Comments

@K4r0qtuYNE5G4qgZ
Copy link

Description

Swallows up to a second at the end of each track (audible) before switching to another.
The displayed length in Navidrome also does not match the file lenghts.

Expected Behaviour

The files/tracks should be played completely before switching to the next file/track.
The displayed length in Navidrome should be rouned correctly.

Steps to reproduce

  1. Open an album with many Tracks
  2. Compare the lenghts in Navidrome with the lenghts o the Files
    or
  3. Open an album with many Tracks (best are such ones that fade out at the end)
  4. Play Tracks and skip to 5-10 sec before end and listen the switch to next Track

Platform information

  • Navidrome version: 0.47.5 (86fe1e3)
  • Browser and version: Chrome 105.0.5195.127 (Official Build) (64-bit)
  • Operating System: Ubuntu 20.04

Additional information

Comparation Pics of Lenghts in Navidrome and the real one in File:
image
image
image
image
image
image
image
image

image
image
image
image
image

As you can see some doesn't match and if I test them in AIMP the play correctly and the lenght is also correct.

My guess is that this is a rounding error in Navidrome because see:

Lenght (Navidrome) - Lenght (AIMP)
04:14                04:15 (04:14.981)
03:23                03:24 (03:23.990)
03:12                03:13 (03.12.533)
03:10                03:11 (03:10.707)

If rouded normally it should be rounded up if over .500 and down if under .500
But I guess it should only be rounded that way for display and not for playback to avoid any audible things.

@deluan
Copy link
Member

deluan commented Oct 11, 2022

Two issues here:

  1. Displayed duration: Yes, it was truncating down. I just changed it in af5c2b5 and now it is rounded like AIMP.
  2. "Swallows up to a second at the end of each track": If you are referring to the silent "gap" between songs, this is because the player we use in Navidrome does not provide Gapless playback #745, and unfortunately there's nothing much we can do at the moment. But you can use a gapless player with Navidrome if you want. Sonixd (a desktop player) is a good example. Let me know if this is what are you referring to.

@K4r0qtuYNE5G4qgZ
Copy link
Author

No, I didn't mean the silent "gap" between songs for (2.) and the "two" issues seem closely related, because I meant it as described it "swallows" the last second eg. the last second is not played at all and it skips to the next. Like I had Tracks that have a fade out in last second that wasn't played at all, clearly audible.

But it's possible that this is because of (1.) eg. Navidrome skips to next exactly at duration end and because it was truncated instead rounded, it swallowed that second on some. So if that truncating was also used in play functions it's quite possible that it was fixed too now.

I gonna re-test that then once the version with the recent fixes is available.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Apr 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants