Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import, display and filter by Label/Publisher #389

Open
Baswazz opened this issue Jul 6, 2020 · 10 comments
Open

Import, display and filter by Label/Publisher #389

Baswazz opened this issue Jul 6, 2020 · 10 comments
Labels

Comments

@Baswazz
Copy link

Baswazz commented Jul 6, 2020

Would be nice if the label/publisher is present in the id3 tag it is visible in the web ui.
When you click on it it filters on all releases by label, like when you click on the artist.

@deluan
Copy link
Member

deluan commented Jul 13, 2020

That's a good idea, thanks! I'll be adding more tags to be imported soon (release type, catalog number, musicbrainz ids, etc...) and will start showing these tags in the UI and add filter for some of them. As the columns of the song grid are not configurable right now, I may not include label as a column for now, but I may add it as a filter, and it will be present in the album/song details

@deluan deluan changed the title Labels Import, display and filter by Label/Publisher Jul 13, 2020
@certuna
Copy link
Contributor

certuna commented Jul 15, 2020

I believe this is officially the TPUB frame in id3v2.x, although MusicBrainz might write its own custom tag?

@deluan
Copy link
Member

deluan commented Jul 15, 2020

@certuna Navidrome uses ffmpeg to read all metadata (tags), so this is what ffmpeg reports:

  • For id3 tags:
Input #0, mp3, from './Nine Inch Nails/The Slip/01-01 999,999.mp3':
  Metadata:
    title           : 999,999
    artist          : Nine Inch Nails
    album           : The Slip
    publisher       : The Null Corporation
  • For Vorbis comments:
Input #0, flac, from './Nine Inch Nails/Ghosts I–IV/01-01 1 Ghosts I.flac':
  Metadata:
    ALBUM           : Ghosts I–IV
    ARTIST          : Nine Inch Nails
    TITLE           : 1 Ghosts I
    LABEL           : The Null Corporation
    PUBLISHER       : The Null Corporation

(I left out irrelevant fields)

So that should be easy. Just don't know what to do with the Vorbis example above: Should I use the Label or the Publisher field? Thoughts?

@certuna
Copy link
Contributor

certuna commented Aug 11, 2020

I'd say read both label and publisher, make it a multi-value field?

@deluan
Copy link
Member

deluan commented Aug 12, 2020

Yeah, that's what I've been thinking: combine all values from both fields, removing duplicates.

@certuna
Copy link
Contributor

certuna commented Mar 25, 2021

Looking into this - as with all text fields, id3v2.4 and Vorbis allow the label field to have multiple values. This in principle means this can't just be stored in the mediaFile table as a simple label field, we need a label table.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@certuna
Copy link
Contributor

certuna commented Mar 13, 2023

Still relevant and valuable

@github-actions github-actions bot removed the stale label Mar 14, 2023
raminou pushed a commit to raminou/navidrome that referenced this issue Mar 28, 2023


Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue Mar 28, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue Mar 28, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 18, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 18, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 18, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 18, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 22, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 22, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 22, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 22, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue May 22, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
raminou pushed a commit to raminou/navidrome that referenced this issue Jun 11, 2023
…#389)

Import from scanning and display in the UI with filtering
Implementation of "publisher" very similar to "genre"
@arnaudgst
Copy link

arnaudgst commented Sep 7, 2023

So how about display and filtering label / Publisher in 2023 ? i just installed navidrome, but can't manage to show them. Is it already active ? do i need to trig something ? many thanks for your help and good work

@paradajz
Copy link
Contributor

Chiming in here. This would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants