Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty albums #937

Closed
rohitgeddam opened this issue Mar 29, 2021 · 15 comments
Closed

Remove empty albums #937

rohitgeddam opened this issue Mar 29, 2021 · 15 comments
Labels

Comments

@rohitgeddam
Copy link
Contributor

Description

I deleted a song from my music folder however the album is still listed in the UI

album_empty

empty_album

It shows1 Song · 03:55 · 8.98 MB but there is no song present since I deleted it from the music folder

Expected Behaviour

The UI must not list empty albums or show wrong information,
There are no songs in this album but it shows 1 Song · 03:55 · 8.98 MB

Steps to reproduce

  1. Delete any song from your music directory.
  2. open the navidrome frontend in browser.
  3. your album might still be listed even after deleting the song from the music folder.
@jvoisin
Copy link
Collaborator

jvoisin commented Mar 29, 2021

This is working as intended.

The next time the scanner will run, it'll detect that the files have been removed. In the meantime, they'll still be displayed in the interface.

@jvoisin jvoisin closed this as completed Mar 29, 2021
@deluan
Copy link
Member

deluan commented Mar 30, 2021

Yes, @jvoisin is correct in that Navidrome should remove the album in the next scan. But this image shows a bug:
empty_album

You should never have empty albums showing in the UI...

@rohitgeddam How is your library setup? Do you have files from different albums in the same folder? How big is your library?

Can you try to reproduce again? After removing the song, try forcing a quick scan (in the Activity Panel). What is the result? Is the album still showing?

@deluan deluan reopened this Mar 30, 2021
@rohitgeddam
Copy link
Contributor Author

  • library setup?

    • I have put all my songs directly in my root music folder
  • Do I have files from different albums in the same folder?

    • yes I have all songs at the root of my music folder
  • How big is my Library?

    • It's pretty small about ( < 50 )
  • reproducing the same again?

    • I removed another song from my music folder and did a manual quick scan, but the empty album is still showing.

empty-album2

@rohitgeddam
Copy link
Contributor Author

rohitgeddam commented Mar 30, 2021

Not sure why it's showing up in the UI, the song entry has been removed from the media_file table in the DB, however, the artist of the removed song is still listed in the artist table in the DB.

It seems like only the media_file table was updated correctly, all other tables like album artist are not getting updated

@armedev
Copy link
Contributor

armedev commented Mar 30, 2021

@rohitgeddam stop your server and try deleting the ./data/ and restart the server, I reproduced the issue and solved this issue by doing so.

@deluan maybe there is a problem in the DB updating while scanning the folders.

@rohitgeddam
Copy link
Contributor Author

@armedev I am afraid that we cannot just delete the data folder since it holds the SQLite DB,
Must be some other way to handle this

@armedev
Copy link
Contributor

armedev commented Mar 31, 2021

@armedev I am afraid that we cannot just delete the data folder since it holds the SQLite DB,
Must be some other way to handle this

Yes, I meant to say to delete data in the development mode to figure out where the bug is.
Maybe in my opinion the data in DB is not updating as expected.

@hellojaccc
Copy link

This issue hasn't been fixed. Please take a look.

@voryzen
Copy link

voryzen commented Sep 24, 2022

bump. I'm encountering this issue too

@jvoisin
Copy link
Collaborator

jvoisin commented Sep 24, 2022

You must be new to Free Software. This (amazing) piece of software is made by people on their free time. They might, or might not fix this particular bug, at some point in the future.

Complaining/bumping it won't make it fixed faster. In fact, it might have the exact opposite effect: "How dare the people giving me this piece of software for free not providing me with free support as well?". The best way to get this issue fixed is to do it yourself, and open a pull request to get it fixed for everyone.

@voryzen
Copy link

voryzen commented Sep 24, 2022

You must be new to Free Software. This (amazing) piece of software is made by people on their free time. They might, or might not fix this particular bug, at some point in the future.

Complaining/bumping it won't make it fixed faster. In fact, it might have the exact opposite effect: "How dare the people giving me this piece of software for free not providing me with free support as well?". The best way to get this issue fixed is to do it yourself, and open a pull request to get it fixed for everyone.

No one asked your opinion, mate. Thanks for giving it, though; really appreciate it.

@deluan
Copy link
Member

deluan commented Sep 25, 2022

This is a well known bug and it happens when all songs of your library are located in the root of the Music Folder, without any subfolder. The workaround is quite simple, instead of:

MusicFolder = /music

Files:
/music/01-song.mp3
/music/02-song.mp3

Just put your songs under a subfolder inside the Music Folder:

MusicFolder = /music

Files:
/music/folder/01-song.mp3
/music/folder/02-song.mp3

As the workaround is very simple, this ticket has very low priority.


@voryzen:

No one asked your opinion, mate.

Not cool man. If you are posting a comment on an open source (read: "free") project and gets a reply from one of the maintainers, you should use the opportunity to start a conversation and be humble about it. It is ok to just say "I'd love to contribute, but I'm not a developer".

Bumping old issues is an action normally not well-received by open source (read: "free") project maintainers, as it only causes noise and more unnecessary notifications. You should only add comments if you have something to add to the issue, like a workaround or document other situations where the bug happens, so it gives more insights about the problem.

If you want to ask others about the issue or need help with it, or just want to join the conversation, you can do this using other communication channels, like our Discord server.

@voryzen
Copy link

voryzen commented Sep 25, 2022

Hi @deluan,

Thanks for the explanation; has this workaround been documented somewhere?
A precursory search doesn't show anything. ( I acknowledge your comment in #868 )

I'm glad you provided some more information, now others that have this issue and are searching for a workaround, can find one.

I'm happy to assist in adjusting the docs, to reflect this workaround; maybe a few well placed admonitions? What are your thoughts here?

@deluan
Copy link
Member

deluan commented Oct 1, 2022

Thanks for the PR, I'll take a look. I'll close this as we now have a documented (here and soon in the FAQ) workaround, and this will be fixed definitely with the new scanner, in a future release.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants