New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PWA notification toolbar color #1083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this, and for testing with multiple themes. Take a look at the comments below
Hey @Dnouv I converted the component into a hook, as it was really not a component and not rendering anything. Thanks for the PR! |
By the way, I'm seeing this error below in the console referring the
|
Thanks a lot, @deluan, for the review, and about this error, I will create a PR to fix it. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As mentioned in issue #1063, in the PWA, the color of the notification bar was not similar to the theme; in this PR, I have tried to fix issue #1063 by setting the toolbar color as the theme's palette
light
color( if it is defined or else to themain
color of the palette). Please find the screenshots of the app after changes, (Fixes #1063 )In Spotify-ish theme:
In Extra-Dark theme:
In Ligera theme:
Feedbacks are most welcomed. Thank you!