Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genre and Comments columns in Songs listview #1219

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Genre and Comments columns in Songs listview #1219

merged 1 commit into from
Jul 2, 2021

Conversation

certuna
Copy link
Contributor

@certuna certuna commented Jul 1, 2021

Genre and Comments columns in Songs listview (hidden by default)

Genre and Comments columns in Songs listview (hidden by default)
@certuna certuna changed the title Update SongList.js Genre and Comments columns in Songs listview Jul 1, 2021
@deluan
Copy link
Member

deluan commented Jul 1, 2021

I agree with Genre, but Comment may make the Grid really weird, is there a specific use case for this?

@certuna
Copy link
Contributor Author

certuna commented Jul 2, 2021

Comments are used by many to store various info, it's practical to have this more accessible in the UI than just inspecting each individual file. Indeed you need a bit of width in your window to display it, but that's also why this column is hidden by default, and only for the desktop view.

Also, most other desktop music players are able to display this column in the Songs view (apple music, foobar2k, musicbee, etc), why restrict Navidrome?

@deluan
Copy link
Member

deluan commented Jul 2, 2021

why restrict Navidrome?

No reason, I know other players do this, I just don't see the value. Specially in Navidrome since grid columns are not resizeable (for now).

Thanks for the contribution :)

@deluan deluan merged commit 77f6bc8 into navidrome:master Jul 2, 2021
@certuna certuna deleted the patch-2 branch July 2, 2021 14:47
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants