-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist Detail Page #1287
Artist Detail Page #1287
Conversation
Cool! There are many ways to expand this album detail page with more elements later but this looks like a great start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dnouv, nice work overall, but please read my comments. Also, I have two considerations for the layout:
- I think it should be consistent to what we have in the
AlbumShow
page, with the image inside the card - The "read more" is confusing as the biography already has a "read more" inside it. Maybe we should follow the same pattern from the Album comment, making a click in any part of the block expand it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments. Let me know if you have any questions.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Greetings,
This PR will introduce an Artist Detail Page.
P.S: Page in progress
Fixes: #961