Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist Detail Page #1287

Merged
merged 32 commits into from
Sep 26, 2021
Merged

Artist Detail Page #1287

merged 32 commits into from
Sep 26, 2021

Conversation

Dnouv
Copy link
Contributor

@Dnouv Dnouv commented Aug 15, 2021

Greetings,
This PR will introduce an Artist Detail Page.

P.S: Page in progress
Fixes: #961

@Dnouv
Copy link
Contributor Author

Dnouv commented Aug 19, 2021

Here is a page preview,
artist

Expanded details:
artist_expand
(The green(at the end of expanded bio paragraph) Read More redirects to LastFM)

In mobile view:

localhost_4533_(iPhone X)

Feedbacks/Suggestions are most welcomed. Thank you!

P.S. Sorry at the moment this page is only designed for desktop view, for the mobile view, the UI for expanded bio is not ready yet. Will add a new page design for the mobile view as soon as possible.

@certuna
Copy link
Contributor

certuna commented Aug 20, 2021

Cool! There are many ways to expand this album detail page with more elements later but this looks like a great start.

@Dnouv
Copy link
Contributor Author

Dnouv commented Aug 26, 2021

Sorry for the delay,
Here is the artist's page on xs displays,

Iphone_X_bio_collapsed Iphone_X_bio_expanded
Please feel free to provide feedback. Thank you!

@Dnouv
Copy link
Contributor Author

Dnouv commented Sep 1, 2021

The recent commits introduce CSS rules for the theme,

I need suggestions for the additional required features on the Artist page, so please let me know here or on discord. Any suggestions/feedbacks are most welcomed. Thank you!

Iphone_X_light Iphone_X_dark

@Dnouv Dnouv marked this pull request as ready for review September 3, 2021 05:55
ui/src/routes.js Outdated Show resolved Hide resolved
Copy link
Member

@deluan deluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dnouv, nice work overall, but please read my comments. Also, I have two considerations for the layout:

  1. I think it should be consistent to what we have in the AlbumShow page, with the image inside the card
  2. The "read more" is confusing as the biography already has a "read more" inside it. Maybe we should follow the same pattern from the Album comment, making a click in any part of the block expand it?

ui/src/common/ArtistLinkField.js Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
@Dnouv Dnouv requested a review from deluan September 9, 2021 18:45
Copy link
Member

@deluan deluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. Let me know if you have any questions.

ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
ui/src/common/ArtistShow.js Outdated Show resolved Hide resolved
@deluan deluan merged commit 482c2de into navidrome:master Sep 26, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artist Detail Page
3 participants