Use local copy of workbox service worker scripts #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only add prod js, without maps. Reduces the size from 170k to 24k - Removed it from build. As it is small now, we can add it to source, and have a script to just update it whenever it is required - Fixed relative paths in navidrome-service-worker.js, should now work with BaseUrl != ''
|
Hey, thanks for this. I actually changed some things in your PR:
Let me know your thoughts or any concerns |
|
Looking great 👍 |
|
Hey @certuna, can you please try your "set" of PWA validations with this build? |
|
yes, I will test this |
|
no issues so far |
Dnouv
pushed a commit
to Dnouv/navidrome
that referenced
this pull request
Oct 4, 2021
* Use local copy of workbox service worker scripts * Refactor workbox integration: - Only add prod js, without maps. Reduces the size from 170k to 24k - Removed it from build. As it is small now, we can add it to source, and have a script to just update it whenever it is required - Fixed relative paths in navidrome-service-worker.js, should now work with BaseUrl != '' Co-authored-by: Deluan <deluan@navidrome.org>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #1147 . Looks like its not that complicated as
workbox-cliprovides anything necessary to make this process painless.However I'm not a JS dev by any means, so I'm not sure if it's a "proper" way of doing this, or just ugly hack (especially the
mv workbox-* workboxpart which ensures consistency of directory name between versions, and keeps only necessary modules). But I believe it's a good starting point, to get rid of this "google call".