Adds Lyrics Support #1379
Merged
Adds Lyrics Support #1379
+169
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheerajdlalwani
force-pushed
the
GSoC_Lyrics_Support
branch
from
641e2cb
to
26ee27d
Compare
db/migration/20210926155612_add_synced_lyrics_column_and_rename_lyrics_to_unsynced_lyrics.go
Outdated
Show resolved
Hide resolved
KartikSoneji
suggested changes
Oct 2, 2021
scanner/mapping_test.go
Outdated
| lyrics7 := "[]" | ||
| lyrics8 := "" | ||
| It("returns false if lyrics contain no timestamps", func() { | ||
| Expect(isSynced(lyrics5)).To(Equal(false)) |
There was a problem hiding this comment.
Expect(isSynced("[02.50]")).To(Equal(false))I don't see the point of rejecting timestamps that use . instead of :.
Is there an official format specification for subtitles?
KartikSoneji
suggested changes
Oct 5, 2021
dheerajdlalwani
force-pushed
the
GSoC_Lyrics_Support
branch
3 times, most recently
from
b890d27
to
a668f30
Compare
deluan
requested changes
Oct 13, 2021
deluan
reviewed
Oct 14, 2021
dheerajdlalwani
force-pushed
the
GSoC_Lyrics_Support
branch
from
d1ba4dc
to
0cf05bb
Compare
…nd add tests for the same
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com>
…rs & clean up code Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com>
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com>
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com>
dheerajdlalwani
force-pushed
the
GSoC_Lyrics_Support
branch
from
0cf05bb
to
634225b
Compare
deluan
requested changes
Oct 18, 2021
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com>
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Lyrics - Subsonic API
Closes #249