Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing 3rd party UIs to access x-total-count http header #1470

Merged
merged 4 commits into from Nov 19, 2021
Merged

Allowing 3rd party UIs to access x-total-count http header #1470

merged 4 commits into from Nov 19, 2021

Conversation

bricej13
Copy link
Contributor

I copied the code from the existing AllowAll() function and added x-content-duration and x-total-count to CORS exposed headers

deluan
deluan requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@deluan deluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Can we move the handler creating to a function (corsHandler?) inside the middlewares.go file? This would help with readability

@bricej13
Copy link
Contributor Author

I moved the changes to middlewares.go

@bricej13 bricej13 requested a review from deluan November 19, 2021 15:02
@deluan deluan merged commit 6d947f6 into navidrome:master Nov 19, 2021
@deluan
Copy link
Member

deluan commented Nov 19, 2021

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deluan deluan Awaiting requested review from deluan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bricej13 @deluan