Allow ArtistExternalLink icons to be styled #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deluan
reviewed
Jan 5, 2022
ui/src/artist/ArtistExternalLink.js
Outdated
Comment on lines
41
to
50
| <svg width="0" height="0" xmlns="http://www.w3.org/2000/svg"> | ||
| <defs> | ||
| <linearGradient id="mb-icon-gradient" x2="1"> | ||
| <stop stopColor="var(--mb-icon-color-one, #FFF)" offset="0%" /> | ||
| <stop stopColor="var(--mb-icon-color-one, #FFF)" offset="50%" /> | ||
| <stop stopColor="var(--mb-icon-color-two, #FFF)" offset="50%" /> | ||
| <stop stopColor="var(--mb-icon-color-two, #FFF)" offset="100%" /> | ||
| </linearGradient> | ||
| </defs> | ||
| </svg> |
There was a problem hiding this comment.
What is this svg required for? If it is really required for the functionality proposed, can't we just move it to the MusicBrainzIcon file itself?
There was a problem hiding this comment.
@srichter, did you see this comment?
There was a problem hiding this comment.
The gradient lets you style the MusicBrainz icon with two colors (to match the official logo). It does make more sense to be inside the svg itself; moved it there.
srichter
force-pushed
the
add-classes-to-artistexternallink-icons
branch
from
8e585b0
to
0e072c9
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds classes to the ArtistExternalLink icons, allowing them to be styled by themes. Additionally, it adds a two-color horizontal gradient that can be styled and used to color the MusicBrainz icon allowing for a split fill.
Themes can style the icons by adding the following to the
overridessection: