New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix signaler not exiting on cancel #1638
Conversation
d512aad
to
6981623
Compare
`break` is incorrect here, as it just breaks out of the select. `return` to exit the function instead. Fixes navidrome#1636. Signed-off-by: Ian Kerins <ianskerins@gmail.com>
6981623
to
8daa370
Compare
Signed-off-by: Ian Kerins <ianskerins@gmail.com>
Tested with my original use case (binding with a bogus
|
@deluan sorry for the ping, but I see you've been merging some things lately. |
Yes, I'm going through all pending PRs and testing them first before merging. I'm planning to have a release with all these PRs soon. Don't worry, this one is on my list :) |
Thanks! |
Working great, thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
break
is incorrect here, as it just breaks out of the select.return
to exit the function instead.Fixes #1636.