Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Warn if track is already present when adding to playlist - 1604 #1897

Merged
merged 2 commits into from Sep 29, 2022
Merged

fix(UI): Warn if track is already present when adding to playlist - 1604 #1897

merged 2 commits into from Sep 29, 2022

Conversation

joaomqc
Copy link
Contributor

@joaomqc joaomqc commented Sep 29, 2022

Closes #1604

Fixes previously existing functionality of showing a warning if a track is already present when adding it to a playlist.

Behavior when skipping a song already in a playlist

skip

Behavior when adding a song already in a playlist

add

Copy link
Member

@deluan deluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this. Looks good, but take a look at the comment below.

ui/src/dialogs/AddToPlaylistDialog.js Show resolved Hide resolved
Signed-off-by: joaomqc <joaomqc@hotmail.com>
@deluan deluan merged commit 8befe10 into navidrome:master Sep 29, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if track is already present when adding to playlist
2 participants