Nord Theme #1899
Merged
Nord Theme #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction visable against background & the toggle. Not ideal.
|
Hey @renere I just found a small issue with links in this theme. There's no visual cue for links, which may be confusing if the user wants to click in artists that don't have a page. See the comparison with Spotify-ish:
You see in the example above, "Franz Ferdinand" has a page and it is clickable, but "The Ordinary Boys" is not. In Nord, there's no distinction, so if the user clicks "The Ordinary Boys" it will play the song, and they may think this is a bug. Can you please make Links have a different color? Thanks! |
|
Sure thing! I'll get working on that now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've polished off the Nord theme tpbnick created.
Do let me know if there's anything you reckon I should adjust!
Also apologies for creating a separate pull request for this, I don't know how to attach it to the pre-existing one (if that's even possible).