Skip to content

Implement Sharing#2106

Merged
deluan merged 36 commits into
masterfrom
shares
Jan 24, 2023
Merged

Implement Sharing#2106
deluan merged 36 commits into
masterfrom
shares

Conversation

@deluan

@deluan deluan commented Jan 22, 2023

Copy link
Copy Markdown
Member

This is an initial implementation of Sharing:

One of the nice features of Subsonic is its ability to generate a sharing link for a track/album/artist/playlist to send to friends, so that they can listen/download the music without having an account on your instance. This is a nice alternative to Youtube links to share music.

As there are still some rough edges, this feature will be disabled by default in 0.49.0. To enable it you'll need to set EnableSharing=true in your configuration.

Notes:

  • If enabled, all users will have access to all current shares, including changing description and expiration, and will be able to create new ones. Currently there's no way to set permissions per user
  • All generated sharable links will have the format: http://yourserver.com/share/XXXXXXXXXX, so if you have Navidrome behind a reverse proxy, be sure to allow traffic to /share

Closes #748

  • Add ways to create and manage shares in the UI
    • Albums
    • Songs
    • Playlists
    • Artists
  • Implement the Subsonic API related endpoints:
    • getShares
    • createShare
    • updateShare
    • deleteShare
  • Add a standalone player (based on our current React Player)
  • Add meta-tags to html (to show some info about the shared music in chat platforms)

@github-actions

github-actions Bot commented Jan 22, 2023

Copy link
Copy Markdown

Download the artifacts for this pull request:

@deluan deluan changed the title Implements Sharing Implement Sharing Jan 23, 2023
@deluan
deluan marked this pull request as ready for review January 24, 2023 22:51
@deluan
deluan merged commit 8aa6939 into master Jan 24, 2023
@deluan
deluan deleted the shares branch January 24, 2023 23:35
@deluan
deluan restored the shares branch January 24, 2023 23:35
@deluan
deluan deleted the shares branch January 24, 2023 23:36
@jan666

jan666 commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

The share button is visible and you can create shares when DevEnableShare=true is not set. There is no "Shares" in the Menu and the created shares do not work - but the button is there and the shares are generated. I guess this is a bug?

@deluan

deluan commented Jan 26, 2023

Copy link
Copy Markdown
Member Author

Yes it is! Fixed now, thanks for reporting.

@morbificagent

morbificagent commented Feb 3, 2023

Copy link
Copy Markdown

Hi there,

wanted to try it, updated to the last git-version and added the DevEnableShare option in the toml...
But even after a restart no "share button" appears...:

image

Did i anything wrong or is it a bug?

@jan666

jan666 commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

@morbificagent it's EnableSharing=true

@morbificagent

Copy link
Copy Markdown

Great, its working with this!
Many thanks

@centralscrutinizer21

Copy link
Copy Markdown

Great work on this feature!
I was wondering what would be the best way to embed the shared link into a static web page (markdown,html, etc.) ?

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 11, 2023
search5 pushed a commit to search5/navidrome that referenced this pull request Apr 28, 2026
XBisATrouble pushed a commit to XBisATrouble/navidrome that referenced this pull request Jun 30, 2026
RFLundgren pushed a commit to RFLundgren/navidrome_experimental that referenced this pull request Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to share a subset of the library

4 participants