add radio-browser search integration #2108

kgarner7 · 2023-01-23T16:21:54Z

This is a draft integration of the Radio Browser API.

It currently does:

Periodic fetching of all station data from radio-browser (currently around 8.78 MB in DB)
Allow searching through various filters
Allow previewing a stream (playing it)
Allow creating a new Internet Radio from the search. This also required additional fields in the radio table

Things missing:

Translation. Most of the API is English, but it could be possible to translate the country code and language code?
Click Metrics. It is requested that clients using this API send a "Click" request when using a server. This is not yet implemented
~~[ ] Proxy/store favicons? Some of them set third-party cookies, which isn't nice. Cons: extra load on Navidrome~~ (to be handled in another request)
Better handling of non-functional streams. Because of CORS (as well as just being broken), some streams will just not play in the web client. I've added a warning, but it would be cool if there is some alternative

github-actions · 2023-01-23T16:37:39Z

Download the artifacts for this pull request:

deluan-tc

Hey @kgarner7 why this is still a draft? Anyway, check my comments. Thanks!

Re: "Translation. Most of the API is English, but it could be possible to translate the country code and language code?", I think it makes sense. We could maybe add the country code in the translation files, and get the translations from there.

deluan-tc · 2023-03-30T22:45:38Z

conf/configuration.go

@@ -276,6 +307,10 @@ func init() {
 	viper.SetDefault("spotify.secret", "")
 	viper.SetDefault("listenbrainz.enabled", true)
 	viper.SetDefault("listenbrainz.baseurl", "https://api.listenbrainz.org/1/")
+	viper.SetDefault("radiobrowser.baseurl", "https://de1.api.radio-browser.info")
+	viper.SetDefault("radiobrowser.enabled", "true")
+	viper.SetDefault("radiobrowser.refreshschedule", "@every 24h")


I'd make the default @weekly

deluan-tc · 2023-03-30T22:48:30Z

core/agents/radiobrowser/agent.go

+)
+
+const (
+	fetchAgentTimeout = 100000000000000 // 100s


Can't you set this as a proper duration? 100 * time.Second

deluan-tc · 2023-03-30T22:51:38Z

core/agents/radiobrowser/agent.go

+
+		toDelete := []string{}
+
+		for id := range existing {


I think you can use the utils.RangeByChunks function here.

deluan-tc · 2023-03-30T22:53:23Z

model/properties.go

@@ -2,7 +2,8 @@ package model

 const (
 	// TODO Move other prop keys to here
-	PropLastScan = "LastScan"
+	PropLastScan    = "LastScan"
+	PropLastRefresh = "LastRefresh"


Maybe rename this to PropLastRadioBrowserRefresh, to be more explicitly ?

deluan-tc · 2023-03-30T22:54:55Z

core/agents/radiobrowser/agent.go

+	})
+}
+
+func RadioBrowserConstructor(ds model.DataStore) *radioBrowserAgent {


"Constructors" in Go, by convention, are named NewXxxx() ;)

deluan-tc · 2023-03-30T22:57:57Z

db/migration/20230122090430_add_cached_radioinfo.go

+
+DROP TABLE radio_tmp;
+	`)
+	// This code is executed when the migration is applied.


Remove this comment.

deluan-tc · 2023-03-30T22:58:02Z

db/migration/20230122090430_add_cached_radioinfo.go

+}
+
+func downAddCachedRadioinfo(tx *sql.Tx) error {
+	// This code is executed when the migration is rolled back.


Remove this comment.

deluan-tc · 2023-03-30T23:35:26Z

core/agents/radiobrowser/agent.go

+	maxQueryVariables = 1000 // You can go higher than this, but just a precaution
+)
+
+type RadioBrowserAgent interface {


Not sure if this classifies as an "Agent", as it is very specific, probably won't be implemented with other service. But if you feel it can be implemented with other services, then it should not update the DB directly, it should only query the API and return a parsed list of radios. The synchronization with the DB should be done in a core service.

deluan-tc · 2023-03-30T23:39:10Z

ui/src/i18n/en.json

@@ -366,6 +385,9 @@
            "musicbrainz": "Open in MusicBrainz"
        },
        "lastfmLink": "Read More...",
+        "originalFormat": "Download in original format",


I don't think we are using this string in the PR.

deluan-tc · 2023-03-30T23:43:35Z

ui/src/App.js

+        permissions === 'admin' ? (
+          <Resource name="radioInfo" {...radioInfo} />
+        ) : undefined,
+        config.devEnableShare && <Resource name="share" {...share} />,


Merge error?

- Merge in master - `/radio` => `/radios`. For some reason `/radio/${id}` just gave me a status=0? If the original one works that'd be great - Move radio search to empty page/radio list - Edit button for existing entries instead

kgarner7 · 2023-04-01T05:58:46Z

This was still in draft mainly for the translations (and in the hope that proxying radios would be looked at first). One weird thing I noticed when testing, for some reason /radio/${id}/ would return with status 0, which is why I changed to /radios. If you can fix that it'd be great. I have no idea why the rest api was not called .-.

deluan · 2023-04-06T15:24:36Z

and in the hope that proxying radios would be looked at first

Do you think the radio proxy PR should go first?

kgarner7 · 2023-04-06T15:31:03Z

If possible, yes. My reasoning is that, currently, the internet radio feature basically requires you to have an existing one in mind. With this feature, it makes searching more likely, which while a good thing, also means that the odds of someone finding a stream that doesn't support work currently more likely...

github-actions · 2023-10-04T01:44:26Z

This PR has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
Please check https://github.com/navidrome/navidrome/blob/master/CONTRIBUTING.md#pull-requests and verify that this code contribution fits with the description. If yes, tell it in a comment.
This PR will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

kgarner7 added 4 commits January 22, 2023 21:03

add radio-browser search integration

b2c04d1

add cooldown for scan on start

1f21b41

make linter happy, click on button stop propagation

67612de

add error warning, better cleanup

68e6cfd

deluan and others added 5 commits January 24, 2023 21:16

Simplify radio CRUD code

6acd059

Merge branch 'master' into radio-search

61244c3

merge simplification

c778def

forward clicks

6aa7301

merge master, refine appearance

8cf6868

deluan force-pushed the master branch from 080ed8f to dad4949 Compare February 5, 2023 05:58

deluan-tc suggested changes Mar 30, 2023

View reviewed changes

Address PR

ff8d879

- Merge in master - `/radio` => `/radios`. For some reason `/radio/${id}` just gave me a status=0? If the original one works that'd be great - Move radio search to empty page/radio list - Edit button for existing entries instead

kgarner7 force-pushed the radio-search branch from 2d02468 to ff8d879 Compare April 1, 2023 05:55

Merge branch 'master' into radio-search

88a0c76

kgarner7 marked this pull request as ready for review April 1, 2023 05:58

github-actions bot added the stale label Oct 4, 2023

github-actions bot closed this Nov 3, 2023

deluan reopened this Nov 8, 2023

deluan added keep and removed stale labels Nov 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add radio-browser search integration #2108

add radio-browser search integration #2108

kgarner7 commented Jan 23, 2023 •

edited

github-actions bot commented Jan 23, 2023 •

edited

deluan-tc left a comment •

edited by deluan

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

deluan-tc Mar 30, 2023

kgarner7 commented Apr 1, 2023

deluan commented Apr 6, 2023

kgarner7 commented Apr 6, 2023

github-actions bot commented Oct 4, 2023

add radio-browser search integration #2108

Are you sure you want to change the base?

add radio-browser search integration #2108

Conversation

kgarner7 commented Jan 23, 2023 • edited

github-actions bot commented Jan 23, 2023 • edited

deluan-tc left a comment • edited by deluan

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kgarner7 commented Apr 1, 2023

deluan commented Apr 6, 2023

kgarner7 commented Apr 6, 2023

github-actions bot commented Oct 4, 2023

kgarner7 commented Jan 23, 2023 •

edited

github-actions bot commented Jan 23, 2023 •

edited

deluan-tc left a comment •

edited by deluan