Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(beep): Remove beep and the files where it was imported #2731

Merged
merged 1 commit into from Dec 21, 2023

Conversation

dmarcoux
Copy link
Contributor

Beep isn't needed anymore since we rely on MPV instead. See the discussion from #2726.

The changes to go.mod and go.sum were done with:

go get github.com/faiface/beep@none
go mod tidy

Beep isn't needed anymore since we rely on MPV instead.

The changes to `go.mod` and `go.sum` were done with:
```
go get github.com/faiface/beep@none
go mod tidy
```

Signed-off-by: Dany Marcoux <git@dmarcoux.com>
@dmarcoux
Copy link
Contributor Author

@ms140569 Could you please have a look? Thank you!

Copy link

Download the artifacts for this pull request:

@deluan deluan merged commit 965fc9d into navidrome:master Dec 21, 2023
6 checks passed
@dmarcoux dmarcoux deleted the chore-remove-beep branch December 21, 2023 13:02
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants