Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAK support #2745

Merged

Conversation

apkatsikas
Copy link
Contributor

@apkatsikas apkatsikas commented Dec 25, 2023

Closes

#2514

Description

Adds support for .tak files.

Tested that transcoded playback works in the web UI, and that import scanning works - but TagLib does not support tak files, so Scanner.Extractor must be set to "ffmpeg".

Tested Jukebox mode using Subsonic API - mpv will play back .tak files and I confirmed that Jukebox mode will work with Navidrome/tak files.

Changes

  • Added .tak to mime_types
  • Added tak file to test fixtures (derived from test.wav)
  • Added test fixes to tag_scanner and walk_dir_tree

Add tak to mime_types audioFormats

Signed-off-by: apkatsikas <apkatsikas@gmail.com>
Add tak test fixture file and add fixes for tag_scanner and walk_dir_tree tests

Signed-off-by: apkatsikas <apkatsikas@gmail.com>
@apkatsikas apkatsikas mentioned this pull request Dec 25, 2023
3 tasks
Copy link

github-actions bot commented Dec 26, 2023

Download the artifacts for this pull request:

@deluan deluan changed the title bug(mime_types): tak support - 2514 Add TAK support Dec 26, 2023
@deluan
Copy link
Member

deluan commented Dec 26, 2023

Thanks for this! We don't really need the comment in the code, we already have some file formats that are only recognized by ffmpeg, like dsf. Besides that, it looks good.

We may need to add a page in the docs describing the differences between the two extractors, and we can add the file format support differences there. But that's aa different issue, no worries about that for now. (unless you are into documentation :) )

consts/mime_types.go Outdated Show resolved Hide resolved
@apkatsikas
Copy link
Contributor Author

Thanks for this! We don't really need the comment in the code, we already have some file formats that are only recognized by ffmpeg, like dsf. Besides that, it looks good.

We may need to add a page in the docs describing the differences between the two extractors, and we can add the file format support differences there. But that's aa different issue, no worries about that for now. (unless you are into documentation :) )

I started my career as a tech writer so this is familiar turf for me :) I can try my hand at adding something in a PR in this repo - https://github.com/navidrome/website

@deluan deluan linked an issue Dec 26, 2023 that may be closed by this pull request
3 tasks
@deluan deluan merged commit b4815ec into navidrome:master Dec 26, 2023
6 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TAK files
2 participants