Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: OS expose release date for album, make original optional #2906

Merged
merged 3 commits into from Apr 3, 2024

Conversation

kgarner7
Copy link
Contributor

Formalizes support for opensubsonic/open-subsonic-api#68. Also makes originalReleaseDate actually optional

Copy link

github-actions bot commented Mar 13, 2024

Download the artifacts for this pull request:

@Tolriq
Copy link

Tolriq commented Mar 13, 2024

Remember that in OS fields that are supported must always be returned for clients to know what the server support.

So fields needs to be returned with empty value as they are now as done currently for original release date.

Copy link
Member

@deluan deluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this! Please take a look at my comment.

server/subsonic/responses/responses.go Outdated Show resolved Hide resolved
@deluan deluan merged commit f12dfb4 into navidrome:master Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants