-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests and CI #62
Fix tests and CI #62
Conversation
The installation on the CI now succeeds, but the tests are failing. I get the same locally, so I will have a look at fixing those. FAILED tests/test_OWSNActorAnalysis.py::test_owsnactoranalysis::test_actor_metrics - TypeError: setRange(self, min: int, max: int): argument 2 has unexpected type 'float'
FAILED tests/test_OWSNActorAnalysis.py::test_owsnactoranalysis::test_image_export - TypeError: setRange(self, min: int, max: int): argument 2 has unexpected type 'float'
FAILED tests/test_OWSNActorAnalysis.py::test_owsnactoranalysis::test_minimum_size - TypeError: setRange(self, min: int, max: int): argument 2 has unexpected type 'float'
FAILED tests/test_OWSNActorAnalysis.py::test_owsnactoranalysis::test_msg_base_class - TypeError: setRange(self, min: int, max: int): argument 2 has unexpected type 'float'
FAILED tests/test_OWSNActorAnalysis.py::test_owsnactoranalysis::test_tagging - TypeError: setRange(self, min: int, max: int): argument 2 has unexpected type 'float' |
Hi @kodymoodley or @ThijsVroegh could either of you review the code and let me know what you think? |
Hi @stefsmeets and @kodymoodley, I'll review it, no problem |
@kodymoodley , perhaps you can also take a look; some things I can't completely follow, so an extras pair of eyes would help |
Okay @ThijsVroegh, I will take a look tomorrow |
Any update on this @kodymoodley or can it be merged? |
Thanks for your work @stefsmeets! I'm 🤒... but I managed to add have a quick look and added a few comments / questions. After those are addressed, I am happy for you to merge! Looks good otherwise! |
No worries, didn't mean to put any work on you while you were off. Thanks for the effort! |
No worries, wasn't too much work. Nice distraction from lying in bed the whole day recuperating :D Thanks for the nice work on the tests as well! |
This PR moves the tests from tox to pytest so that they are more easy to run locally and in the CI. I also updated the github actions so that the vm does not blow up.
Closes #61
Closes #31
Closes #24