issue54, changed ids to numeric #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kodymoodley, could you also review and merge this one? 😅 It's only a small fix so should't take too long |
kodymoodley
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
@ThijsVroegh The code looks fine to me. But just test it on 5-10 stories first before merging. You can select some short ones from the dataset so it is easy for you to verify.
|
Hi @kodymoodley, perfect! I will do a couple of additional checks before merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves issue #54: output sentences of the Actors widget were presented in the wrong order
Description of changes
We (TV + ET) fixed two problems:
story idandsentence_idcolumns instory_elements_dfwere strings before sorting on line 217 in file actoranalysis.py which caused unexpected orderings. The format was changed to integerstoryidandsentence_idas well when checking for duplicatesIncludes