Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/list #1823

Merged
merged 60 commits into from Feb 28, 2023
Merged

New/list #1823

merged 60 commits into from Feb 28, 2023

Conversation

kschieren
Copy link
Contributor

Endret litt CSS for å støtte nested lists

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2023

🦋 Changeset detected

Latest commit: be7668c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@navikt/ds-codemod Patch
@navikt/ds-css Patch
@navikt/ds-react Patch
@navikt/ds-tailwind Patch
@navikt/ds-tokens Patch
@navikt/ds-icons Patch
@navikt/ds-css-internal Patch
@navikt/ds-react-internal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Endringer til review: 2

eca8b3c5d | 45 komponenter | 250 stories

@KenAJoh
Copy link
Collaborator

KenAJoh commented Feb 24, 2023

🙌 Vært nice med en storybook-story for nested-lister.

@KenAJoh
Copy link
Collaborator

KenAJoh commented Feb 27, 2023

Screenshot 2023-02-27 at 09 55 43

Margin-top for nested-list er nå 40px, samme som margin-bottom. Kan sikkert synke med @olejorgenbakken, men kanskje vært bra med enten mindre margin-top eller større margin-bottom for bedre hierarki 🤔

@olejorgenbakken
Copy link
Contributor

Dette var jo mitt påfunn, så @kschieren skal ikke ha skylda for dette designet, men det beste hadde kanskje vært margin: 36px 0 44px 0; på nested lists?

@kschieren
Copy link
Contributor Author

Dette var jo mitt påfunn, så @kschieren skal ikke ha skylda for dette designet, men det beste hadde kanskje vært margin: 36px 0 44px 0; på nested lists?

Ja det kan vi få til

@olejorgenbakken
Copy link
Contributor

Er den good to go?

Copy link
Contributor

@olejorgenbakken olejorgenbakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En verdig avskjed @kschieren 👋 😶‍🌫️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants