Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ V3, Accordion og ikonoppdatering #1964

Merged
merged 12 commits into from May 9, 2023
Merged

✨ V3, Accordion og ikonoppdatering #1964

merged 12 commits into from May 9, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented May 8, 2023

Accordion

  • Accordion oppdateres til å ha chevron left-aligned.
  • Neutral-variant
  • Diverse nye size-options

Ikonoppdatering

ds-react og ds-react-internal bruker nå aksel-icons

Sideeffects av ikonendringer

  • Komponenter som tidligere brukte Expand-ikon har fått oppdatert animasjon (table, readmore og accordion)
  • Alert bruker samme ikonstørrelse for alle størrelser
  • Chips har justert padding/ikonstørrelser
  • Datepicker hover-bug på knapper er fikset
  • Helptekst bruker nå et custom-ikon.
  • Select har fått justert padding rundt ikon
  • Switch bruker samme checkmark som checkbox, er nå avrundet
  • ReadMore har justert margin for alignment med ikon, fjernet content-animasjon
  • Tabs bruker default text-default nå
  • Stepper har endret hvordan den styler checkmark-ikon.

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023 •
edited

🦋 Changeset detected

Latest commit: ecac090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@navikt/ds-css Major
@navikt/ds-react Major
@navikt/ds-react-internal Major
@navikt/aksel Major
@navikt/ds-tokens Major
@navikt/ds-tailwind Major
@navikt/ds-css-internal Major
@navikt/ds-codemod Major
@navikt/aksel-icons Major
@navikt/ds-icons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023 •
edited

Endringer til review: 1

5da6b0b21 | 44 komponenter | 262 stories

KenAJoh and others added 6 commits May 8, 2023 10:57
@KenAJoh
💄 Justert small/xsmall button med ikon
c372915
@JulianNymark @github-actions
@KenAJoh @AndreasDybdahl
updates to accordion (#1933)
cac3b6f 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Co-authored-by: Ken <ken.aleksander@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: AndreasDybdahl <andreas.dybdahl@nav.no>
@KenAJoh
🐛 Fixed small-button size
a19eb98
@KenAJoh
📝 Oppdatert changeset
71bfe06
@KenAJoh
📝 Endret eksempel navn sizes -> size
989d4ea
@KenAJoh
🐛 Fixed hover-bug when content overlays header
374d49a
@KenAJoh KenAJoh marked this pull request as ready for review May 8, 2023 11:16
@KenAJoh KenAJoh merged commit 166ee5f into main May 9, 2023
3 checks passed
@KenAJoh KenAJoh deleted the v3-major branch May 9, 2023 10:06
@github-actions github-actions bot mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
klar for gjennomgang 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KenAJoh @JulianNymark