Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Datepicker og Monthpicker lukker nå popover ved escape #2052

Merged
merged 1 commit into from Jun 15, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jun 15, 2023

https://nav-it.slack.com/archives/C7NE7A8UF/p1686825045350629

Dette kom fra en regresjon ved oppdatering til nyeste versjon av floating-ui der escape ikke lengre bubbler opp eventen gjennom dom-treet. Dette er i grunn en positiv endring slik at f.eks Modaler ikke lukkes ved lukking av popover, men brakk da implementasjonen vår av Datepicker og Monthpicker.

📝 PR Checklist

  • Run yarn changeset for version and changelog generation

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: 9d65795

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

e2bdb983f | 45 komponenter | 267 stories

@KenAJoh KenAJoh merged commit 7c17e40 into main Jun 15, 2023
2 checks passed
@KenAJoh KenAJoh deleted the datepicker-esc-fix branch June 15, 2023 12:46
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant