Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Combobox , SingleSelect: allow custom options #2180

Merged
merged 5 commits into from Aug 17, 2023

Conversation

larseirikhansen
Copy link
Contributor

Description

Change summary

  • fix: SingleSelect didn't properly allow for custom options, now does
  • fix: Adding a custom option and listed option didn't remove the other, so you had chosen two options. Now fixed.

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 6de5bc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

49eb4b9df | 48 komponenter | 309 stories

@KenAJoh KenAJoh merged commit e7cb375 into main Aug 17, 2023
2 checks passed
@KenAJoh KenAJoh deleted the combobox-singleselect-allow-custom-options branch August 17, 2023 09:38
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants