Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Modal: use polyfill in JSDOM #2208

Merged
merged 6 commits into from Aug 23, 2023
Merged

✅ Modal: use polyfill in JSDOM #2208

merged 6 commits into from Aug 23, 2023

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Aug 23, 2023

JSDOM støtter ikke <dialog>, noe som gjør at tester feiler når man prøver å åpne en modal. Denne PRen aktiverer polyfillen når koden kjøres i JSDOM.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: eedd386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Storybook demo

Endringer til review: 5

5244c6d5b | 48 komponenter | 320 stories

@HalvorHaugan HalvorHaugan merged commit 02d7f91 into main Aug 23, 2023
2 checks passed
@HalvorHaugan HalvorHaugan deleted the new-modal-jsdom-pf branch August 23, 2023 14:24
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants