Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Oppdatert Typo-komponenter #2211

Merged
merged 31 commits into from Aug 28, 2023
Merged

🎨 Oppdatert Typo-komponenter #2211

merged 31 commits into from Aug 28, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Aug 23, 2023

Change summary

  • Skrevet nye og bedre stories for alle typo-komponenter
  • Skrevet nye og bedre typo demoer for aksel.nav.no
  • Lagt til size="large" på BodyShort og BodyLong
  • Som konsekvens er <Ingress /> tagget som deprecated (anbefaler bruk av bodylong large)

Nye props

  • BodyLong: truncate, weight, align, visuallyHidden, textColor

  • BodyShort: truncate, weight, align, visuallyHidden, textColor

  • Detail: truncate, weight, align, visuallyHidden, textColor

  • Label: truncate, align, visuallyHidden, textColor

  • Heading: align, visuallyHidden, textColor

  • Ingress har ingen endringer siden den nå regnes som deprecated

  • ErrorMessage har ingen nye props

Kan trekke oppdateringer av eksempler ut i en egen PR, men kan også filterer filer i PR-en for å se de mest relevante:
Screenshot 2023-08-23 at 23 16 46

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: e9193a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Minor
@navikt/ds-react Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Storybook demo

Endringer til review: 47

176e23957 | 54 komponenter | 355 stories

@KenAJoh KenAJoh merged commit 03cdeff into main Aug 28, 2023
3 checks passed
@KenAJoh KenAJoh deleted the typo-update-2208 branch August 28, 2023 16:38
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants