Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add Bleed #2278

Merged
merged 20 commits into from Sep 26, 2023
Merged

✨ add Bleed #2278

merged 20 commits into from Sep 26, 2023

Conversation

JulianNymark
Copy link
Contributor

Description

add Bleed layout component

Change summary

Lets you easily add negative margins to anything using our spacing tokens.

PR Checklist πŸ“ (Remove fields after check!)

New component? ✨

  • Check that component-styling is correctly configured in @navikt/core/css/config/_mappings.js. This is needed for correct build and CDN upload.
  • Check that styling is correctly exported from @navikt/core/css/index.css
  • Check that correct tokens for component is documented in @navikt/core/css/tokens.json
  • Check that only needed components and types are exported from @navikt/core/react/src/index.ts
  • Add JSDoc to component (see other components for reference)
  • Create storybook-stories for relevant component variations and compositions. Stories are used for visual regression testing, so make sure they are complete.
  • Is the component sufficiently complex to warrant tests? Add some unit-tests for jest.

Documentation πŸ“

  • Add/update component-demos for component aksel.nav.no/website/pages/eksempler
  • Create/Update documentation in sanity if needed
    Note: Props, tokens and examples only updates to sanity on merge to main

Versioning 🏷️

  • Run yarn changeset to generate a version-entry for change.
    • Bug/hotfix: Patch
    • New feature: Minor
    • Breaking change: Major
  • Adding breaking changes? Consider adding a codemod for easier migration.
  • Breaking changes also needs documentation under "Migration"-page on website

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

πŸ¦‹ Changeset detected

Latest commit: 175e625

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JulianNymark
Copy link
Contributor Author

Needs breakpoints (or remove if not)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Storybook demo

Endringer til review: 6

00d8882ca | 59 komponenter | 382 stories

@JulianNymark JulianNymark merged commit 6535c22 into main Sep 26, 2023
2 checks passed
@JulianNymark JulianNymark deleted the primitives-bleed branch September 26, 2023 13:41
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants