Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Box: Forenkling av CSS-variabler #2279

Merged
merged 3 commits into from Sep 14, 2023
Merged

♻️ Box: Forenkling av CSS-variabler #2279

merged 3 commits into from Sep 14, 2023

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Sep 13, 2023

Dette er slik Polaris gjør det i Bleed.

La også på bakgrunnsfarger på storyene som viser padding, slik at paddingen blir enklere å se.

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: b9cb4d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Storybook demo

Endringer til review: 6

abe2080ff | 57 komponenter | 372 stories

@KenAJoh
Copy link
Collaborator

KenAJoh commented Sep 13, 2023

👏 Ser ut som en god optimalisering. Kan kanskje sette opp en story med Box i Box for å dobbelsjekke inheritance (men ser ut som det bør fungere uansett)

@HalvorHaugan HalvorHaugan changed the title Forslag til forenkling av CSS i Box ♻️ Box: Forenkling av CSS-variabler Sep 14, 2023
@HalvorHaugan HalvorHaugan changed the title ♻️ Box: Forenkling av CSS-variabler ♻️ Box: Forenkling av CSS-variabler Sep 14, 2023
@HalvorHaugan HalvorHaugan marked this pull request as ready for review September 14, 2023 08:38
@sjur-gr
Copy link
Contributor

sjur-gr commented Sep 14, 2023

Kanskje til hjelp, fant denne https://lyts.christiankaindl.com/components/box

@HalvorHaugan HalvorHaugan merged commit ddf13d7 into main Sep 14, 2023
2 checks passed
@HalvorHaugan HalvorHaugan deleted the box-css-forslag branch September 14, 2023 10:42
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants