Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Radio/Checkbox-border har nå outside shadow for background-bleed #2388

Merged
merged 2 commits into from Oct 20, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Oct 17, 2023

Description

Resolves #2013
Closes #2187

Border på Radio/Checkbox er nå "outside" bakgrunn, som gjør at border blir mørkere på andre bakgrunner enn default

Change summary

  • Bruker nå standard box-shadow uten inset
  • Width/Height er endret + padding for å preservere størrelse

Hvordan teste:

  • Åpne storybook
  • Åpne Radio/Checkbox-story
  • Endre bakgrunn på canvas til annen farge
  • Teste states (hover, focus, active, selected) + kombinasjoner

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 5c66344

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KenAJoh KenAJoh changed the title 🎨 Forms-border har nå outside shadow for background-bleed 🎨 Radio/Checkbox-border har nå outside shadow for background-bleed Oct 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Storybook demo

Endringer til review: 2

461be1316 | 59 komponenter | 387 stories

@KenAJoh KenAJoh merged commit 3d1b0ac into main Oct 20, 2023
2 checks passed
@KenAJoh KenAJoh deleted the form-border-bleed branch October 20, 2023 07:21
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: <Radio />
1 participant