Ikke rendre child som ikke er valid element i ErrorSummary #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d41b2de The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
torkjels
force-pushed
the
err-summary-ikke-rendre-undefined
branch
from
1c5abba
to
994b0f4
Compare
torkjels
commented
Nov 16, 2023
Storybook demo0a703a9eb | 61 komponenter | 398 stories |
torkjels
force-pushed
the
err-summary-ikke-rendre-undefined
branch
from
994b0f4
to
2aa1a72
Compare
KenAJoh
reviewed
Nov 17, 2023
torkjels
force-pushed
the
err-summary-ikke-rendre-undefined
branch
from
2aa1a72
to
020e598
Compare
torkjels
changed the title
KenAJoh
approved these changes
Nov 17, 2023
Dette gjør det mulig å conditionally rendre barn i ErrorSummary. For eksempel kan man nå gjøre:
```
const shouldShow = false
return (
<ErrorSummary>
{shouldShow && <ErrorSummary.Item href="#id1">Jeg er en feilmelding, men vises ikke</ErrorSummary.Item>}
<ErrorSummary.Item href="#id2">Jeg er en feilmelding som vises!</ErrorSummary.Item>
</ErrorSummary>
)
```
torkjels
force-pushed
the
err-summary-ikke-rendre-undefined
branch
from
020e598
to
d41b2de
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hvis man i dag prøver å rendre noe conditionally i
ErrorSummaryvil man se et listepunkt (aka bullet point) selvom conditionen evaluerer til false. Eksempel:Denne fiksen gjør det mulig å conditionally rendre barn i
ErrorSummary. For eksempel kan man nå gjøre:Change summary
ErrorSummary