Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tag][Feature] Tags med ikon #2611

Merged
merged 10 commits into from Jan 12, 2024
Merged

[Tag][Feature] Tags med ikon #2611

merged 10 commits into from Jan 12, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jan 11, 2024

Description

Resolves https://github.com/navikt/team-aksel/issues/420
Resolves #2371

Change summary

  • Tag har nå nye prop icon
  • Lagt til stories for chromatic-testing
  • Lagt til demo for Aksel.nav.no

Tester bruk av has-selector her. Er 91% støttet i Norge, så tenker det er ikke så farlig om 10% mister 2px gap mellom ikon og tekst

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 70996f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Storybook demo

Endringer til review: 1

c961ca07a | 61 komponenter | 401 stories

@KenAJoh KenAJoh merged commit 642f188 into main Jan 12, 2024
3 checks passed
@KenAJoh KenAJoh deleted the tags-med-ikon-420 branch January 12, 2024 12:19
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: <Tag />
3 participants