Combobox complex options #2716
Merged
Combobox complex options #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the allowNewValues prop, and simplify returning a value from onToggleSelected.
🦋 Changeset detectedLatest commit: d24b149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 17dab96792 | 60 komponenter | 226 stories |
… Storybook-examples, as we have limited the format for now
# Conflicts: # @navikt/core/react/src/form/combobox/combobox.stories.tsx # yarn.lock
…lity function. Fixes missing checkmark for selected items in FilteredOptions.
it-vegard
commented
Feb 27, 2024
…ese are outdated/unsynced, and will be inherited from parent package.json instead.
JulianNymark
reviewed
Mar 1, 2024
HalvorHaugan
reviewed
Mar 1, 2024
@navikt/core/react/src/form/combobox/FilteredOptions/filteredOptionsContext.tsx
Outdated
Show resolved
Hide resolved
@navikt/core/react/src/form/combobox/FilteredOptions/filteredOptionsContext.tsx
Outdated
Show resolved
Hide resolved
HalvorHaugan
reviewed
Mar 1, 2024
aksel.nav.no/website/pages/eksempler/combobox/with-complex-options.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/eksempler/combobox/with-complex-options.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
…ther of these return a value
… larger, and the SelectedOptions label uses a short code (the value) Also made the isInList function better, by checking both label and value when checking ComboboxOptions. Pass just the value or just the label if you only want to check either of them.
…ayToComboboxOptionArray)
…n't belong in the documentation
# Conflicts: # yarn.lock
…ptions, even if it didn't match the search text. This broke autocomplete.
HalvorHaugan
previously approved these changes
Mar 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow Combobox options as a list of objects, to support richer Options and separating the displayed label and the programmatical value used internally.
Change summary
Add support for Combobox.options as
{ label: "Some label", value: "a value" }in addition to the oldstring[]options.