Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ fix types for modal issue #2744

Merged
merged 13 commits into from Feb 21, 2024
Merged

🏷️ fix types for modal issue #2744

merged 13 commits into from Feb 21, 2024

Conversation

JulianNymark
Copy link
Contributor

fix modal typing issues

should solve the following:

Ser at om både aria-label og aria-labelledby er definert på modal (som ikke er lov nå) får jeg feil om at header mangler som kan skape litt forvirring om du ikke vet at de ikke kan kombineres, og jeg får ikke feil om alle 3 er satt

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 1e757f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Storybook demo

f5faa4f40 | 57 komponenter | 221 stories

KenAJoh
KenAJoh previously approved these changes Feb 21, 2024
@JulianNymark JulianNymark merged commit c0c812b into main Feb 21, 2024
2 checks passed
@JulianNymark JulianNymark deleted the issues-v6-typings branch February 21, 2024 12:37
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
JulianNymark added a commit that referenced this pull request Feb 26, 2024
* 🏷️ fix types for modal issue

* liten style justering

* Tester!

* changeset

* tester test

* tester test 2

* tester test 3

* Revert experiments, add proper tests

* fix Portal.stories.tsx

* 🏷️ Endret rekkefølge på modal conditional-typer for bedre feilmelding

* revert rekkefølge

* testkode

---------

Co-authored-by: Halvor Haugan <halvor.haugan@nav.no>
Co-authored-by: Ken <ken.aleksander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants