Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ new FormSummary component #2802

Merged
merged 88 commits into from
Apr 15, 2024
Merged

✨ new FormSummary component #2802

merged 88 commits into from
Apr 15, 2024

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented Mar 19, 2024

Description

The form summary shows a summary of the form! 😎 (will become a pattern as well maybe?) But this is just the component.

TODO

  • Vurder støtte for "inline"-variant uten ramme og header. Men da trengs kanskje redigeringsknapp per svar. Burde kanskje lages som separat komponent, men kan gjenbruke/wrappe denne.
    • tenker det kan bli egen task / komponent senere 🙌
  • Finne ut hvordan det bør se ut når verdien er tom (ikke besvart/utfylt).
  • Oppdater kodeeksempel.
  • UU review.
    • Er det best med flere dd-er eller ul/li når det er flere svar?
  • List-style: disc?
    • nope, will not have it
  • Flytte ts inn i /form, eller flytte css ut av form

This is to be used in 2 places where we iterate over children and add <hr /> components between them all.

It also wraps the children in a <Box>, which is used here and not really reflected in the name of the function 🤔
Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: f7f80f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Storybook demo

Endringer til review: 1

d5c7cebad | 61 komponenter | 201 stories

@JulianNymark JulianNymark requested a review from a team April 2, 2024 08:43
@JulianNymark JulianNymark marked this pull request as ready for review April 2, 2024 08:44
@navikt/core/css/config/_mappings.js Outdated Show resolved Hide resolved
@navikt/core/css/form/form-summary.css Outdated Show resolved Hide resolved
@navikt/core/css/form/form-summary.css Outdated Show resolved Hide resolved
@navikt/core/css/primitives/hr.css Outdated Show resolved Hide resolved
@navikt/core/react/src/form-summary/FormSummary.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/form-summary/FormSummaryValue.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/form-summary/index.ts Outdated Show resolved Hide resolved
@navikt/core/react/src/form-summary/utils.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/form-summary/FormSummaryHeader.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/form-summary/FormSummaryHeading.tsx Outdated Show resolved Hide resolved
@JulianNymark JulianNymark merged commit 3a73a02 into main Apr 15, 2024
3 checks passed
@JulianNymark JulianNymark deleted the summary-component branch April 15, 2024 07:53
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants