Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE10: Persistence + Flytte tokenvalidering til SAM. Fjerne SubjectHandler #1319

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

jolarsen
Copy link
Collaborator

@jolarsen jolarsen commented Aug 26, 2023

IKKE MERGE før testet videre
Har flyttet tokenvalideringen opp fra LoginModule til SAM + WS-interceptor.
Har beholdt en Dummy LoginModule pga https://jakarta.ee/specifications/authentication/3.0/jakarta-authentication-spec-3.0#loginmodule-bridge-profile
Fjernet SubjectHandler. Bør virke med Jetty12 - kan testes ved å cherry-pick'e commit over til EE10-branch

Er testet lokalt med Jetty12 i fpsak+fpabakus.

@jolarsen jolarsen requested a review from mrsladek August 26, 2023 23:21
@jolarsen jolarsen requested a review from a team as a code owner August 26, 2023 23:21
@jolarsen jolarsen force-pushed the feature/flytt-atutentisering-opp-fra-loginmodule branch from 7ebc28a to 87a4f0c Compare August 27, 2023 17:31
@jolarsen jolarsen force-pushed the feature/flytt-atutentisering-opp-fra-loginmodule branch from e331614 to e4d9db2 Compare November 13, 2023 09:27
@jolarsen jolarsen force-pushed the feature/flytt-atutentisering-opp-fra-loginmodule branch from e4d9db2 to e3de97f Compare December 1, 2023 22:53
@jolarsen jolarsen changed the title Flytte tokenvalidering fra Login til SAM. Fjerne SubjectHandler EE10: Persistence + Flytte tokenvalidering til SAM. Fjerne SubjectHandler Dec 3, 2023
Copy link
Collaborator

@mrsladek mrsladek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lurte på om maven bør ikke bumpes til å bruke EE10 deps her?

@mrsladek
Copy link
Collaborator

mrsladek commented Dec 5, 2023

Du må i hvertfall bumpe fp-bom til en versjon med oppdaterte dependencies til EE10

@mrsladek mrsladek self-requested a review December 5, 2023 17:48
Copy link
Collaborator

@mrsladek mrsladek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trenger en oppdatert EE10 fp-bom versjon

@jolarsen
Copy link
Collaborator Author

jolarsen commented Dec 5, 2023

@mrsladek Jeg hadde commitet sist helgs testing, men glemt å pushe. OK nå.

@jolarsen jolarsen merged commit 9b10af4 into master Dec 5, 2023
5 of 6 checks passed
@jolarsen jolarsen deleted the feature/flytt-atutentisering-opp-fra-loginmodule branch December 5, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants