Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Får metrikker over konsumenter og typer token som brukes. #1341

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

mrsladek
Copy link
Collaborator

Enkel prometheus counter som teller validerte tokens og fordeler på klient, konsument, tokenType og identType, acrLevel (kun tokenx).

Det blir enklere å identifisere evtl konsumentene som ikke bruker azure mot oss.

@mrsladek mrsladek requested a review from a team as a code owner December 12, 2023 12:39
Copy link
Collaborator

@espenwaaga espenwaaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flott initiativ!

@mrsladek mrsladek merged commit 89c95b3 into master Dec 12, 2023
3 of 4 checks passed
@mrsladek mrsladek deleted the prometheus_counter_konsumenter branch December 12, 2023 15:06
@jolarsen
Copy link
Collaborator

jolarsen commented Dec 12, 2023

Hvorfor her i felles og så brått?
Man har alltid tokenprovider tilgjengelig fra KontekstHolder
Jeg ville heller lagt det in FP-sak sitt TimingFilter da får du metode fra ContainerRequestContext
Det er bare tpsak og fpabakus som kalles fra utenfor namespace. Konsumentene kom fram fra treverket da ingress ble endret fra fpsak til fpsak-api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants