Legg etikett presentasjon fullmakt #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathiamu
reviewed
Jun 26, 2024
| @@ -47,7 +47,7 @@ function OppgaveInnerForm({ | |||
| tema={tema} | |||
| veilederId={veilederId} | |||
| formikProps={formikProps} | |||
| enhetId={!!enhetId ? enhetId : avsenderenhetId} | |||
| enhetId={enhetId ? enhetId : avsenderenhetId} | |||
There was a problem hiding this comment.
Denne er vel grei å beholde som den var? SonarCloud liker ikke endringen, så hvis vi ikke vil bruke !! så burde vi endre uttrykket
Comment on lines
+61
to
+80
| export interface FullmaktData { | ||
| fullmaktsgiver: StringOrNothing; | ||
| fullmektig: StringOrNothing; | ||
| omraade: OmraadeMedHandling[]; | ||
| gyldigFraOgMed: StringOrNothing; | ||
| gyldigTilOgMed: StringOrNothing; | ||
| fullmaktsgiverNavn: StringOrNothing; | ||
| fullmektigsNavn: StringOrNothing; | ||
| } | ||
|
|
||
| export interface OmraadeMedHandling { | ||
| tema: StringOrNothing; | ||
| handling: OmraadeHandlingType[]; | ||
| } | ||
|
|
||
| export enum OmraadeHandlingType { | ||
| LES = 'LES', | ||
| KOMMUNISER = 'KOMMUNISER', | ||
| SKRIV = 'SKRIV' | ||
| } |
There was a problem hiding this comment.
I og med at vi ikke bruker denne dataen til noe, kunne vi unngått å lagre den? Sånn for dataminimeringens skyld, kan vi forenkle modellen til å bare være om det eksisterer en fullmakt eller ikke? 🤔
added 2 commits
June 26, 2024 14:09
…egg-etikett-presentasjon-fullmakt
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denne PRen handler om å vise etikett "ReprFullmakt" når person har fullmakt i den nye kilden (Representasjon)