Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON formatter #4

Merged
merged 4 commits into from
Jun 3, 2016
Merged

Conversation

mootpointer
Copy link
Contributor

@mootpointer mootpointer commented May 31, 2016

This adds a :formatter option to the plug, which lets you chose which
formatter you wish to use.

Formatting for the current format has been moved to Logster.StringFormatter
and a new Logster.JSONFormatter has been added to provide the JSON
formatting.

Still to do:

  • Update Documentation
  • ???

@review-ninja
Copy link

ReviewNinja

@mootpointer mootpointer mentioned this pull request Jun 1, 2016
@navinpeiris
Copy link
Owner

So sorry @mootpointer, been crazy busy the last couple of days. Looks good to me! If you can add something to the README as well, I'll merge and push a new version through

@mootpointer
Copy link
Contributor Author

@navinpeiris Done.

@navinpeiris
Copy link
Owner

Wow, beautiful! Thanks @mootpointer!

@navinpeiris navinpeiris merged commit 75e080d into navinpeiris:master Jun 3, 2016
@mootpointer mootpointer deleted the formatters branch June 3, 2016 03:58
@mootpointer
Copy link
Contributor Author

Closes #3

@navinpeiris
Copy link
Owner

version 0.2.0 released with your changes @mootpointer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants