Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_volume treats volumes as convex hulls #10

Closed
jefferis opened this issue Jul 27, 2017 · 3 comments
Closed

in_volume treats volumes as convex hulls #10

jefferis opened this issue Jul 27, 2017 · 3 comments

Comments

@jefferis
Copy link
Contributor

Uses scipy to test if points are within a given CATMAID volume. The idea is to test if adding the point to the cloud would change the convex hull.

Doesn't this implicitly assume that the volume is a convey hull? Think about the convex hull of the mushroom body which looks a bit like a pyramid. It seems to me that a point could be inside the pyramid but far outside the alpha shape defining the mushroom body and still pass this test.

@schlegelp
Copy link
Collaborator

Good point! Will see if I can use scipy.spatial.Delaunay instead.

@schlegelp
Copy link
Collaborator

schlegelp commented Jul 30, 2017

Found a library that does has no external dependency which uses Octrees to intersect rays with volumes: pyoctree (https://github.com/mhogg/pyoctree)

For example see here

Initial tests look promising. Will run some more to check performance before implementing.

@schlegelp
Copy link
Collaborator

Implemented with commit ba4b266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants