Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckAdditionalMarkers returns false positives #6

Closed
rorre opened this issue Mar 14, 2020 · 1 comment
Closed

CheckAdditionalMarkers returns false positives #6

rorre opened this issue Mar 14, 2020 · 1 comment

Comments

@rorre
Copy link

rorre commented Mar 14, 2020 •
edited

Easy example: "Believer" (https://osu.ppy.sh/beatmapsets/1079693#osu/2258888)
image

seems to be caused by this regex: (?i)([^A-Za-z0-9]+)?(ver(\\.|sion)?|size)([^A-Za-z0-9]+)?$ (can't seem to find CheckAdditionalMarkers in this repo tho)
the regex above matches Believer which i believe isnt expected as there is no marker inside the title.
@Naxesss
Copy link
Owner

Naxesss commented Mar 14, 2020 •
edited

yeah I removed this check entirely in exchange for covering the last "version/size"-type metadata standardization, "(Sped Up Ver.)", see commit message below

have a few more things I want to fix before I release the current version done and released

@Naxesss Naxesss closed this as completed Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rorre @Naxesss