Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable search on several resource types #7

Merged
merged 7 commits into from
Sep 15, 2020

Conversation

Jasopaum
Copy link
Contributor

Hello!
We started to use fhirpath but had several features to deliver that were not possible in the current version. That's why we started to work on a fork. Unfortunately, things got a little messy but we're in the process of trying to clean what we did and chunk it into "atomic" PRs. Here's the first one 馃檪

Here, we try to make it possible to search on several resource types instead of just one. I don't know if you had an idea of how you wanted to do that. We chose to add this functionality by changing as less code as we could but maybe it wasn't the best way.

There are some issues that we may need to fix before merging:

  • We broke the field selection with fhirpath (I think it's mandatory to fix this one).
  • We had to change the API of some classes/functions of yours.

Anyway, we'd love some feedback on what we did even if it implies more work on our side!

@nazrulworld
Copy link
Owner

@Jasopaum Thank you so much for the great effort. Looks everything fine! just some minor issue

  1. all tests should be passed (but if you want, we can merge it now and make broken tests working together) because that will kind of make sure other existing providers will not break.
  2. please add your name in AUTHOR.rst and update CHANGES.rst

@Jasopaum Jasopaum closed this Sep 11, 2020
@Jasopaum Jasopaum reopened this Sep 11, 2020
@nazrulworld
Copy link
Owner

Thanks a lot.

@nazrulworld nazrulworld merged commit c8c1cd6 into nazrulworld:master Sep 15, 2020
@Jasopaum Jasopaum deleted the multi-types branch September 15, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants