Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint support. Replace pass with type for handling magics #302

Merged
merged 13 commits into from Oct 12, 2020
Merged

Pylint support. Replace pass with type for handling magics #302

merged 13 commits into from Oct 12, 2020

Commits on Oct 11, 2020

  1. Support for pylint. 

    Pending tests to be added

Changes to be committed:
	new file:   nbqa/handle_magics.py
	modified:   nbqa/save_source.py
	modified:   tests/test_black.py
	modified:   tests/test_flake8_works.py
	modified:   tests/test_other_magics.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    f26e6fe View commit details
    Browse the repository at this point in the history

  2. Added docstrings for the newly added methods and module. 

    Changes to be committed:
	modified:   nbqa/handle_magics.py
	modified:   nbqa/save_source.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    92278c4 View commit details
    Browse the repository at this point in the history

  3. Refactor handle_magics module. 

    Changes to be committed:
	modified:   nbqa/handle_magics.py
	modified:   nbqa/notebook_info.py
	modified:   nbqa/replace_source.py
	modified:   nbqa/save_source.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    b0917fb View commit details
    Browse the repository at this point in the history

  4. Added docstrings for all functions, classes and methods. 

    Changes to be committed:
	modified:   nbqa/handle_magics.py
	modified:   nbqa/notebook_info.py
	modified:   nbqa/replace_source.py
	modified:   nbqa/save_source.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    f1499f2 View commit details
    Browse the repository at this point in the history

  5. Make MagicHandler as Abstract base class. 

    On branch line_magic_with_type
Your branch is ahead of 'upstream/master' by 4 commits.
  (use "git push" to publish your local commits)
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    e7534df View commit details
    Browse the repository at this point in the history

  6. Added tests for pylint. Also ran nbqa against all pymc3 notebooks and… 

    … verified output against one complete notebook manually. No crashes.

Changes to be committed:
	modified:   nbqa/__main__.py
	new file:   tests/test_pylint_works.py
	modified:   tests/test_return_code.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    e8e9a2e View commit details
    Browse the repository at this point in the history

  7. Escape regex containing path. On windows tox failed due to regex pars… 

    …e issues with path patterns unescaped.

Changes to be committed:
	modified:   nbqa/__main__.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    48d6ea1 View commit details
    Browse the repository at this point in the history

  8. Made regex containing path as raw string. 

    Changes to be committed:
	modified:   nbqa/__main__.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    3779402 View commit details
    Browse the repository at this point in the history

  9. Escape the path characters which form the regex pattern 

    Changes to be committed:
	modified:   nbqa/__main__.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    90bc3db View commit details
    Browse the repository at this point in the history

  10. Use replace instead of regex, since regex has issues with handling wi… 

    …ndows path.

Changes to be committed:
	modified:   nbqa/__main__.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    6e6a57d View commit details
    Browse the repository at this point in the history

  11. Fix failing pylint test that used regex involving paths. 

    Changes to be committed:
	modified:   tests/test_pylint_works.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    96074c2 View commit details
    Browse the repository at this point in the history

  12. Fix issues with formatters like black when line length is configured … 

    …to be less then the replacement python code used to substitute ipython magics.

Changes to be committed:
	modified:   nbqa/handle_magics.py
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    edeff4a View commit details
    Browse the repository at this point in the history

  13. Update readme to add support for pylint 

    Changes to be committed:
	modified:   README.md
    @girip11
    girip11 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    0a9d37a View commit details
    Browse the repository at this point in the history