Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch deprecation warning #463

Merged
merged 2 commits into from Nov 15, 2020

Conversation

MarcoGorelli
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 14, 2020

Codecov Report

Merging #463 (00cd245) into master (c5e532b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #463   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          713       716    +3     
=========================================
+ Hits           713       716    +3     
Impacted Files Coverage Δ
nbqa/handle_magics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e532b...00cd245. Read the comment docs.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 1.29 ⭐ 1.26 ⭐ -0.03 👍
Method Length 30.35 ⭐ 31.00 ⭐ 0.65 👎
Working memory 7.36 🙂 7.33 🙂 -0.03 👍
Quality 83.07% 83.10% 0.03% 👍
Other metrics Before After Change
Lines 443 447 4
Changed files Quality Before Quality After Quality Change
nbqa/handle_magics.py 83.07% ⭐ 83.10% ⭐ 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nbqa/handle_magics.py LineMagicHandler._restore_magic_with_modified_code 2 ⭐ 74 🙂 13 😞 65.55% 🙂 Extract out complex expressions
nbqa/handle_magics.py LineMagicHandler.replace_magic 2 ⭐ 71 🙂 12 😞 67.58% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@MarcoGorelli MarcoGorelli merged commit 8b8a4c9 into nbQA-dev:master Nov 15, 2020
@MarcoGorelli MarcoGorelli deleted the catch-deprecation-error branch November 15, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants