Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Levels fail to load with the color restoration mod of Super Mario Advance 4 #282

Closed
Adamillo opened this issue Mar 5, 2023 · 3 comments
Closed

Levels fail to load with the color restoration mod of Super Mario Advance 4 #282

Adamillo opened this issue Mar 5, 2023 · 3 comments
Assignees
@fleroviux
Labels
bug hw: sio

Comments

@Adamillo
Copy link

Adamillo commented Mar 5, 2023 •
edited
Loading

The levels load fine in open AGB firm on the 3DS so technically the game should run fine on real GBA hardware as well. Link to the ROM hack: https://www.romhacking.net/hacks/3315/
This was tested with the latest Nightly build
@fleroviux fleroviux self-assigned this Mar 5, 2023
@fleroviux
Copy link
Member

It appears that this hack does not like my Serial IO IRQ stub. When I remove the stub, the levels successfully load.
This shouldn't be too difficult to fix - just needs some extra checks when the IRQ really should be asserted I think.

@fleroviux fleroviux mentioned this issue Mar 20, 2023
Closed
fleroviux added a commit that referenced this issue Mar 26, 2023
@fleroviux
Bus: SIO: make the serial IRQ stub more accurate (fixes #282) (2)
942d2d8
@fleroviux
Copy link
Member

@Adamillo Sorry, I forgot to mention this until now, but this issue should be fixed in the 1.7 release from a few days ago.

@Adamillo
Copy link
Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fleroviux fleroviux

Labels
bug hw: sio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fleroviux @Adamillo