-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] - mGBA Suite Crashes on NBA 1.7 #301
Comments
Weird. I use this test suite regularly for regression testing. That being said it's possible that I missed something. I'll take a look tonight. |
For a sanity check I also did it on a completely separate system and v1.7 did crash on that one too. Let me know if you want me to test anything. |
Looks like this crash is connected to the recent implementation of the mGBA logging interface, which I wonder if the crash happens if nothing drains from stdout and its buffer eventually is being overrun. |
Turns out This is now accounted for by catching and ignoring the exception. |
Glad to have helped and thank you for your contributions to GBA emulation. |
…ite to STDOUT (fixes nba-emu#301)" This reverts commit ff8f402.
…ite to STDOUT (fixes nba-emu#301)" This reverts commit ff8f402.
…ite to STDOUT (fixes nba-emu#301)" This reverts commit ff8f402.
…ite to STDOUT (fixes nba-emu#301)" This reverts commit ff8f402.
…ite to STDOUT (fixes nba-emu#301)" This reverts commit ff8f402.
…ite to STDOUT (fixes nba-emu#301)" This reverts commit ff8f402.
* CMake: Update CMakeLists files Remove unnecessary project declarations. Bump minimum required CMake version in preparation for FetchContent usage. Some cleanups. * CMake: Drop FindSDL2 module SDL packages ship necessary files. * CMake: Switch to system/FetchContent-provided toml11 * CMake: Switch to system/FetchContent-provided unarr * CMake: Switch to system/FetchContent-provided fmt * Remove Git submodules * CI: Remove submodules checkout * Revert "Catch fmt::print throwing std::system_error when it cannot write to STDOUT (fixes #301)" This reverts commit ff8f402. * Bus: Fix compilation * Docs: Update compiling instructions --------- Co-authored-by: Mireille <fleroviux@gmail.com>
When you try to run endrift's gba-suite on NanoBoyAdvance 1.7 some of the test will outright crash the program.
This behavior is easily replicated by running the latest suite.gba file (suite.gba date modified 3/27/2023) on NBA v1.7 and attempting to run the tests.
However the same suite.gba file runs without issue on all tests for NBA v1.6 and v1.5, and does not crash.
The text was updated successfully, but these errors were encountered: