[HOTFIX] find_outlier_trials() bug (#72)

nbara · Nov 28, 2023 · e60074b · e60074b
1 parent dc3c29c
commit e60074b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/citation.cff b/citation.cff
@@ -5,7 +5,7 @@ authors:
   given-names: "Nicolas"
   orcid: "https://orcid.org/0000-0003-1495-561X"
 title: "MEEGkit"
-version: 0.1.5
+version: 0.1.6
 doi: 10.5281/zenodo.10210992
-date-released: 2023-11-27
+date-released: 2023-11-28
 url: "https://github.com/nbara/python-meegkit"
diff --git a/meegkit/__init__.py b/meegkit/__init__.py
@@ -1,5 +1,5 @@
 """M/EEG denoising utilities in python."""
-__version__ = "0.1.5"
+__version__ = "0.1.6"
 
 from . import asr, cca, detrend, dss, lof, ress, sns, star, trca, tspca, utils
 

diff --git a/meegkit/utils/denoise.py b/meegkit/utils/denoise.py
@@ -223,7 +223,7 @@ def find_outlier_trials(X, thresh=None, show=True):
         plt.show()
 
     thresh = thresh[1:]
-    if thresh:
+    if thresh.any():
         bads, _ = find_outlier_trials(X[:, idx], thresh, show)
         idx = np.setdiff1d(idx, idx[bads])
 

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -238,7 +238,7 @@ def test_outliers(show=False):
     idx, _ = find_outlier_trials(x, 2, show=show)
     np.testing.assert_array_equal(idx, np.arange(5))
 
-    idx, _ = find_outlier_trials(x, [2, 2], show=True)
+    idx, _ = find_outlier_trials(x, [5, 2, 2], show=True)
     np.testing.assert_array_equal(idx, np.arange(5))
 
     idx = find_outlier_samples(x, 5)