Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][ENH] Add regularization option for ASR #18

Merged
merged 8 commits into from
Nov 16, 2020
Merged

Conversation

nbara
Copy link
Owner

@nbara nbara commented Nov 10, 2020

Fixes #17

@nbara nbara added bug Something isn't working enhancement New feature or request labels Nov 10, 2020
@nbara nbara self-assigned this Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #18 (80654a6) into master (a7d98ea) will increase coverage by 2.49%.
The diff coverage is 91.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   72.03%   74.53%   +2.49%     
==========================================
  Files          16       18       +2     
  Lines        1874     2054     +180     
==========================================
+ Hits         1350     1531     +181     
+ Misses        524      523       -1     
Impacted Files Coverage Δ
meegkit/utils/asr.py 95.62% <87.03%> (+15.98%) ⬆️
meegkit/asr.py 85.94% <96.87%> (ø)
meegkit/utils/covariances.py 96.02% <100.00%> (ø)
meegkit/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d98ea...80654a6. Read the comment docs.

@nbara nbara merged commit 1e8c7cf into master Nov 16, 2020
@nbara nbara deleted the nb/fix-issue-16 branch February 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: Covariance matrices must be positive definite. Add regularization to avoid this error.
1 participant